LS26001308: kup-data-table: fix group and sort date column#2848
Merged
lucafoscili merged 1 commit intodevelopfrom Apr 21, 2026
Merged
LS26001308: kup-data-table: fix group and sort date column#2848lucafoscili merged 1 commit intodevelopfrom
lucafoscili merged 1 commit intodevelopfrom
Conversation
lucafoscili
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how cell values are compared and sorted in the Ketchup data utilities, aiming to clarify and standardize the use of raw and decoded values during sorting and comparison operations. The main improvements involve consistently passing both the raw and decoded values to comparison functions and ensuring that the correct value is used depending on the data type (number, date, time, etc.).
Comparison and sorting logic improvements:
compareCellandcompareValuesincell-utils.tsto explicitly pass bothvalueanddecodefields, rather than using a fallback with??, making the logic clearer and more predictable.compareValuesto usedecodeif available, otherwise fallback tovalue, improving the handling of display vs. raw values.valuefield for parsing and conversion, ensuring accurate type-specific comparisons. [1] [2]Sorting helper adjustments:
kup-data-cell-helper.tsto always pass bothvalueand the result ofgetValueForDisplay2tocompareValues, removing conditional logic based on type checks.